-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnodev): add balances & keybase support #1938
Conversation
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
- Coverage 48.25% 48.23% -0.02%
==========================================
Files 408 409 +1
Lines 62338 62349 +11
==========================================
- Hits 30081 30076 -5
- Misses 29749 29765 +16
Partials 2508 2508 ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
64d60d8
to
80e4f99
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the docs, left some comments. Thanks 🙏
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
8d0a0b8
to
1012bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
And works even better 👏
Super stoked for this feature, it's the one thing keeping me from switching to gnodev full time (well, also tx predeploying)
@gfanton the CI is going bananas, please check it when you merge in |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
c0aeefe
to
e4ac3c1
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
e87ba15
to
18ba179
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
18ba179
to
55b863f
Compare
@zivkovicmilos @leohhhn had to update some parts of the code related to Keybase because I had some misconceptions about how it was working. I've created a new package dedicated to storing address keys along with their names. |
Address #1935
This PR brings significant enhancements to
gnodev
. It adds features like customizing user balances, loading keybases, and specifying realm paths with query-like options. Here are the key changes:gnodev
now loads the user's home Keybase by default, providing premine for listed keys.-add-account
flag to add accounts easily in the format<account>[=<amount>]
. The amount is optional and corresponds to the initial balance the user will have.gnodev ./myrealm?creator=foo&deposit=42ugnot
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description