-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add simple userbook realm #1949
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
- Coverage 48.28% 46.62% -1.66%
==========================================
Files 409 492 +83
Lines 62217 69966 +7749
==========================================
+ Hits 30039 32622 +2583
- Misses 29668 34622 +4954
- Partials 2510 2722 +212 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, but a couple things to take a closer look at.
We can merge it, but not with r/demo/pagination as explained earlier. Also, avoid merging it with r/demo/registration or r/demo/signup, as they resemble "the official gnoland registration system." Kindly suggest a new name, make the change, and notify me to proceed. 👍 |
@moul renamed it to |
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR introduces a change to the Getting Started section in the docs. As discussed with @moul, it makes sense to have `gnodev` take the spotlight in the "Local setup" section. With this PR, I've modified the "Local setup" section to reflect the use of `gnodev`. I've moved the "Setting up a local chain" & "Premining balances" out of this section, as they will belong better in a new section which will contain new chain initialization flows. ~Dep. on #1949 Latest preview: https://www.loom.com/share/a9d354b7234843fb8108f1698cc28b5c?sid=92850b75-5153-4f8b-aa0d-bb9d3aa0d6fd <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR introduces a change to the Getting Started section in the docs. As discussed with @moul, it makes sense to have `gnodev` take the spotlight in the "Local setup" section. With this PR, I've modified the "Local setup" section to reflect the use of `gnodev`. I've moved the "Setting up a local chain" & "Premining balances" out of this section, as they will belong better in a new section which will contain new chain initialization flows. ~Dep. on gnolang#1949 Latest preview: https://www.loom.com/share/a9d354b7234843fb8108f1698cc28b5c?sid=92850b75-5153-4f8b-aa0d-bb9d3aa0d6fd <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Description
This PR arose out of a necessity to have a simple, permissionless realm for demonstration purposes. The idea is that people can sign up once with their address, and the Render function will paginate 50 addresses per page, as well as include a UI to go to the next/previous page. This realm will serve 3 purposes:
gnoweb
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description