fix(gno test): pass ExecContext when initializing imported packages #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… imports containing an init() func Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
=======================================
Coverage 54.96% 54.96%
=======================================
Files 481 481
Lines 67391 67400 +9
=======================================
+ Hits 37040 37049 +9
Misses 27330 27330
Partials 3021 3021 ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
github-actions
bot
added
the
📦 ⛰️ gno.land
moul
requested review from
deelawn,
mvertes,
zivkovicmilos and
a team
as code owners
thehowl
approved these changes
May 9, 2024
There was a problem hiding this comment.
I took some liberty to modify this PR, for good reason. I tried copying over the files to master, but could see they were succeeding...
However, I saw the practical changes and saw where the bug could occur. I modified your test case so that it tests for a case which does indeed fail on master.
thehowl
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 8fe571f (#880).
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description