Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnovm): Implement conversion of Gno interface types with methods to Go types #1975

Closed
wants to merge 1 commit into from

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Apr 24, 2024

Description

Implements the functionality to convert Gno interface types with methods to Go types.

Main changes

  1. Modified the gno2GoType function:
    • For instances with methods, use the collectInterfaceMethods function to collect method information and convert to a struct type to represents each methods.
  2. Implemented the rest InterfaceType part in the gno2GoTypeMatches function:
    • Compare the informations (e.g., identifer, params type, number of methods) of Gno interface and Go interface to determine if they match.

Related to #1929

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Apr 24, 2024
@thehowl
Copy link
Member

thehowl commented Apr 24, 2024

I am explicitly against adding any new functionality to gonative unless absolutely necessary, so can you please justify why you need this change?

@notJoon
Copy link
Member Author

notJoon commented Apr 25, 2024

I am explicitly against adding any new functionality to gonative unless absolutely necessary, so can you please justify why you need this change?

I implemented it because I thought the associated PR needed it. but after validated it again, the problem was elsewhere, not here, so I'm closing this PR.

@notJoon notJoon closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants