Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump max faucet drip amount #1977

Merged
merged 2 commits into from
Apr 24, 2024
Merged

feat: bump max faucet drip amount #1977

merged 2 commits into from
Apr 24, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR bumps the max faucet drip amount from 1gnot to 10gnot, to accommodate the desired Faucet Hub functionality (drip amounts in range 1gnot, 5gnot, 10gnot).

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 24, 2024
@zivkovicmilos zivkovicmilos self-assigned this Apr 24, 2024
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner April 24, 2024 10:14
@zivkovicmilos
Copy link
Member Author

@gnolang/tech-staff does this amount seem excessive?

@leohhhn leohhhn self-requested a review April 24, 2024 13:12
leohhhn
leohhhn approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 GNOT seems alright, let's go with this and modify it down the line if needed.

@thehowl thehowl merged commit a1e3b01 into gnolang:master Apr 24, 2024
17 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/bump-faucet-gnot branch April 24, 2024 17:18
@Kouteki Kouteki mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leohhhn leohhhn leohhhn approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

Assignees

@zivkovicmilos zivkovicmilos

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
💪 Bounties & Worx
Status: Done
🧐 Review Meeting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zivkovicmilos @ajnavarro @leohhhn @thehowl