Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: split r/demo/boards #1989

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

refactor!: split r/demo/boards #1989

wants to merge 6 commits into from

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Apr 28, 2024 •
edited
Loading

BREAKING CHANGE!

Found another p which imports r. It should not happen.

This PR splits r/demo/boards into r/demo/boards and p/demo/boards. Now p/demo/groups imports p/demo/boards instead of r/demo/boards

Related: #1393

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 28, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.44%. Comparing base (88b9aa3) to head (42c2a5e).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1989   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files         409      409           
  Lines       61967    61967           
=======================================
  Hits        30019    30019           
  Misses      29448    29448           
  Partials     2500     2500

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harry-hov harry-hov marked this pull request as ready for review April 28, 2024 16:17
@harry-hov harry-hov requested review from a team as code owners April 28, 2024 16:17
@harry-hov harry-hov mentioned this pull request May 3, 2024
Draft
@harry-hov harry-hov requested a review from a team May 5, 2024 16:32
@Kouteki Kouteki mentioned this pull request May 6, 2024
Open
@Kouteki Kouteki assigned Kouteki and unassigned harry-hov Jun 14, 2024
@Kouteki Kouteki marked this pull request as draft June 14, 2024 09:31
@Kouteki Kouteki removed their assignment Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltzmaxwell ltzmaxwell ltzmaxwell left review comments

@Kouteki Kouteki Kouteki left review comments

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: No status
🧐 Review Meeting
Status: No status
🧙‍♂️gno.land core team
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harry-hov @ltzmaxwell @Kouteki