fix(tm2/std)!: use snake_case JSON fields for MemFile and MemPackage #2019
Conversation
thehowl
requested review from
moul,
jaekwon,
piux2 and
zivkovicmilos
as code owners
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 54.67% 54.68% +0.01%
==========================================
Files 583 583
Lines 78502 78503 +1
==========================================
+ Hits 42923 42933 +10
+ Misses 32371 32366 -5
+ Partials 3208 3204 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Let me coordinate a change on the JS clients before we merge it out 🫡 |
|
@thehowl can you merge in the master changes? |
…le-package-snake-case
|
@zivkovicmilos done! |
|
I opened up an analogue PR for the JS clients: |
|
I opened a PR for Adena to support the changes. |
|
For historical record: We released |
…nolang#2019) This PR changes the MemFile and MemPackage to use `snake_case` fields for their JSON key names. This matches what all other objects in transactions do. A new test ensures that no transaction objects within the VM keeper have uppercase runes within their exported json fields. **BREAKING CHANGE:** old `m_addpkg` and `m_run` transactions will stop working. Clients will need to update accordingly, and this change needs to be synced like gnolang#1939. cc/ @zivkovicmilos @gnolang/berty @gnolang/onbloc --------- Co-authored-by: Miloš Živković <milos.zivkovic@tendermint.com>
This PR changes the MemFile and MemPackage to use
snake_casefields for their JSON key names. This matches what all other objects in transactions do. A new test ensures that no transaction objects within the VM keeper have uppercase runes within their exported json fields.BREAKING CHANGE: old
m_addpkgandm_runtransactions will stop working. Clients will need to update accordingly, and this change needs to be synced like #1939.cc/ @zivkovicmilos @gnolang/berty @gnolang/onbloc