fix(tm2/gnovm): multi-msg overwrites previous event(s) #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
+ Coverage 49.14% 49.26% +0.11%
==========================================
Files 576 576
Lines 77597 78318 +721
==========================================
+ Hits 38137 38585 +448
- Misses 36368 36611 +243
- Partials 3092 3122 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leohhhn
changed the title
|
Can you provide the code you used to get the block output from the PR description? |
oh result is actual chain result (:26657/block_results) |
moul
reviewed
May 5, 2024
moul
reviewed
May 5, 2024
7 tasks
|
Could you add a test verifying the behavior? Thanks! |
github-actions
bot
added
🧾 package/realm
ajnavarro
approved these changes
May 22, 2024
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
moul
approved these changes
May 22, 2024
r3v4s
force-pushed
the
fix/multi-msg-overwrites-previous-event
branch
from
2fffb57
to
6c292a2
Compare
thehowl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2028
root cause:
deferwas used inside of loop that handles multi-msg. It was causing vm to use only last appended event valueAS-IS
{ "jsonrpc": "2.0", "id": "", "result": { "height": "43", "results": { "deliver_tx": [ { "ResponseBase": { "Error": null, "Data": null, "Events": [ { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event", "type": "other", "func": "Other", "attrs": [ { "key": "k", "value": "v" } ] }, { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event", "type": "other", "func": "Other", "attrs": [ { "key": "k", "value": "v" } ] } ], "Log": "msg:0,success:true,log:,events:[]\nmsg:1,success:true,log:,events:[]", "Info": "" }, "GasWanted": "2000000", "GasUsed": "270168" } ], "end_block": { "ResponseBase": { "Error": null, "Data": null, "Events": null, "Log": "", "Info": "" }, "ValidatorUpdates": null, "ConsensusParams": null, "Events": null }, "begin_block": { "ResponseBase": { "Error": null, "Data": null, "Events": null, "Log": "", "Info": "" } } } } }TO-BE (in this PR)
{ "jsonrpc": "2.0", "id": "", "result": { "height": "6", "results": { "deliver_tx": [ { "ResponseBase": { "Error": null, "Data": null, "Events": [ { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event2", "type": "t", "func": "inner", "attrs": [ { "key": "k", "value": "v" } ] }, { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event2", "type": "t", "func": "Hello", "attrs": [ { "key": "k", "value": "v" } ] }, { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event", "type": "t", "func": "inner", "attrs": [ { "key": "k", "value": "v" } ] }, { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event", "type": "t", "func": "Hello", "attrs": [ { "key": "k", "value": "v" } ] }, { "@type": "/tm.gnoEvent", "pkg_path": "gno.land/r/demo/event", "type": "other", "func": "Other", "attrs": [ { "key": "k", "value": "v" } ] } ], "Log": "msg:0,success:true,log:,events:[{gno.land/r/demo/event2 t inner [{k v}] \u003cnil\u003e} {gno.land/r/demo/event2 t Hello [{k v}] \u003cnil\u003e} {gno.land/r/demo/event t inner [{k v}] \u003cnil\u003e} {gno.land/r/demo/event t Hello [{k v}] \u003cnil\u003e}]\nmsg:1,success:true,log:,events:[{gno.land/r/demo/event2 t inner [{k v}] \u003cnil\u003e} {gno.land/r/demo/event2 t Hello [{k v}] \u003cnil\u003e} {gno.land/r/demo/event t inner [{k v}] \u003cnil\u003e} {gno.land/r/demo/event t Hello [{k v}] \u003cnil\u003e} {gno.land/r/demo/event other Other [{k v}] \u003cnil\u003e}]", "Info": "" }, "GasWanted": "2000000", "GasUsed": "270168" } ], "end_block": { "ResponseBase": { "Error": null, "Data": null, "Events": null, "Log": "", "Info": "" }, "ValidatorUpdates": null, "ConsensusParams": null, "Events": null }, "begin_block": { "ResponseBase": { "Error": null, "Data": null, "Events": null, "Log": "", "Info": "" } } } } }FYI, unable to provide any test cases(unit test, integration test or txtar) due to lack of multi-msg testing.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description