feat!: remove flag -transpile from gno test

[harry-hov]

The -transpile flag in the gno test command duplicates the functionality of the standalone gno transpile command. Removed the unnecessary -transpile flag from the gno test command.

gno test should only be focused on testing!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.98%. Comparing base (0d299c3) to head (ab90f24).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
+ Coverage   49.96%   49.98%   +0.02%     
==========================================
  Files         578      578              
  Lines       77864    77808      -56     
==========================================
- Hits        38903    38896       -7     
+ Misses      35839    35790      -49     
  Partials     3122     3122              

Flag	Coverage Δ
gnovm	45.16% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thehowl]

cc @moul wdyt?

it seems that transpiling mostly served the purpose of attempting to build the transpiled go source; ie. static checking. though, effectively, this is moved to gno lint in #1730 . I tend to agree with @harry-hov to separate the concerns

[moul]

My goal with this flag was to have « gno test » exiting 0 of everything is OK and 1 of anything is bad.

‘before this flag, we basically had to run two commands to « test ».

ideally we should remove the flag but have a stronger type checking.

as soon as we’re testing to transpire on the CI, I’m fine removing the flag.

[harry-hov]

ideally we should remove the flag but have a stronger type checking.

I agree. I think @thehowl is already working on this!

as soon as we’re testing to transpire on the CI, I’m fine removing the flag.

We already have workflow for transpiling /examples

gno/.github/workflows/examples.yml

Line 33 in 5a64b25

- run: go run ./gnovm/cmd/gno transpile -v --gobuild ./examples

Infact we never run gno test with -transpile flag on CI.

[moul]

Let's remove the flag. Let's keep transpile in the CI and wait for stronger type checking to make gno test testing everything, as it should.

[thehowl]

We'll add type checking in gno test with #1730