-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more telemetry #2059
Merged
zivkovicmilos
merged 21 commits into
gnolang:master
from
zivkovicmilos:feat/improve-telemetry
May 24, 2024
Merged
feat: add more telemetry #2059
zivkovicmilos
merged 21 commits into
gnolang:master
from
zivkovicmilos:feat/improve-telemetry
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
added
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
labels
May 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
- Coverage 49.14% 48.98% -0.17%
==========================================
Files 576 576
Lines 77616 77736 +120
==========================================
- Hits 38148 38078 -70
- Misses 36377 36568 +191
+ Partials 3091 3090 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
please watch #2032 |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
…ilos/gno into feat/improve-telemetry
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
zivkovicmilos
requested review from
a team,
moul,
gfanton and
thehowl
as code owners
May 13, 2024 18:15
deelawn
reviewed
May 22, 2024
gfanton
approved these changes
May 23, 2024
deelawn
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1829
This PR introduces new metrics for different TM2 modules, as outlined in #1829.
Thank you @gfanton and @ajnavarro for helping out with the Docker issues 🙏
How do I test this out?
Head over to
misc/telemetry
and follow the README -- you can run everything locally in Docker 😎cc @mazzy89
Metrics added
Consensus
Networking
JSON-RPC
Mempool
VM
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description