fix: global var dependencies

gnovm/pkg/gnolang/preprocess.go

@@ -3073,6 +3073,237 @@
 	return findUndefined2(store, last, x, nil)
 }
 
+// finds the next undefined identifier and returns it if it is global
+func findUndefined2SkipLocals(store Store, last BlockNode, x Expr, t Type) Name {
+	name := findUndefined2(store, last, x, t)
+
+	existsLocal := func(name Name, bn BlockNode) bool {
+		curr := bn
+		for {
+			currNames := bn.GetBlockNames()
+
+			for _, currName := range currNames {
+				if currName == name {
+					return true
+				}
+			}
+
+			if bn.GetStaticBlock().Source == curr {
+				return false
+			}
+
+			curr = bn.GetStaticBlock().GetParentNode(store)
+
+			if curr == nil {
+				return false
+			}
+		}
+	}
+
+	if name != "" {
+		pkg := packageOf(last)
+
+		if _, _, ok := pkg.FileSet.GetDeclForSafe(name); !ok {
+			return ""
+		}
+
+		isLocal := existsLocal(name, last)
+
+		if isLocal {
+			return ""
+		}
+	}
+
+	return name
+}
+
+func findUndefinedStmt(store Store, last BlockNode, stmt Stmt, t Type) Name {
+	switch s := stmt.(type) {
+	case *TypeDecl:
+		un := findUndefined2SkipLocals(store, last, s.Type, t)
+
+		if un != "" {
+			return un
+		}
+	case *ValueDecl:
+		un := findUndefined2SkipLocals(store, last, s.Type, t)
+
+		if un != "" {
+			return un
+		}
+		for _, rh := range s.Values {
+			un := findUndefined2SkipLocals(store, last, rh, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *DeclStmt:
+		for _, rh := range s.Body {
+			un := findUndefinedStmt(store, last, rh, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *IncDecStmt:
+		un := findUndefined2SkipLocals(store, last, s.X, t)
+
+		if un != "" {
+			return un
+		}
+	case *PanicStmt:
+		un := findUndefined2SkipLocals(store, last, s.Exception, t)
+
+		if un != "" {
+			return un
+		}
+	case *BlockStmt:
+		for _, rh := range s.Body {
+			un := findUndefinedStmt(store, s, rh, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *DeferStmt:
+		un := findUndefined2SkipLocals(store, last, s.Call.Func, t)
+
+		if un != "" {
+			return un
+		}
+
+		for _, rh := range s.Call.Args {
+			un = findUndefined2SkipLocals(store, last, rh, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *SwitchStmt:
+		un := findUndefined2SkipLocals(store, last, s.X, t)
+		if un != "" {
+			return un
+		}
+
+		un = findUndefinedStmt(store, last, s.Init, t)
+		if un != "" {
+			return un
+		}
+
+		for _, b := range s.Clauses {
+			b := b
+			un = findUndefinedStmt(store, s, &b, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *SwitchClauseStmt:
+		for _, rh := range s.Cases {
+			un := findUndefined2SkipLocals(store, last, rh, t)
+
+			if un != "" {
+				return un
+			}
+		}
+
+		for _, b := range s.Body {
+			un := findUndefinedStmt(store, last, b, t)
+
+			if un != "" {
+				return un
+			}
+		}
+
+	case *ExprStmt:
+		return findUndefined2SkipLocals(store, last, s.X, t)
+	case *AssignStmt:
+		for _, rh := range s.Rhs {
+			un := findUndefined2SkipLocals(store, last, rh, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *IfStmt:
+		un := findUndefinedStmt(store, last, s.Init, t)
+		if un != "" {
+			return un
+		}
+
+		un = findUndefined2SkipLocals(store, last, s.Cond, t)
+		if un != "" {
+			return un
+		}
+
+		un = findUndefinedStmt(store, last, &s.Else, t)
+		if un != "" {
+			return un
+		}
+
+		un = findUndefinedStmt(store, last, &s.Then, t)
+		if un != "" {
+			return un
+		}
+	case *IfCaseStmt:
+		for _, b := range s.Body {
+			un := findUndefinedStmt(store, last, b, t)
+
+			if un != "" {
+				return un
+			}
+		}
+	case *ReturnStmt:
+		for _, b := range s.Results {
+			un := findUndefined2SkipLocals(store, last, b, t)
+			if un != "" {
+				return un
+			}
+		}
+	case *RangeStmt:
+		un := findUndefined2SkipLocals(store, last, s.X, t)
+		if un != "" {
+			return un
+		}
+
+		for _, b := range s.Body {
+			un := findUndefinedStmt(store, last, b, t)
+			if un != "" {
+				return un
+			}
+		}
+	case *ForStmt:
+		un := findUndefinedStmt(store, s, s.Init, t)
+		if un != "" {
+			return un
+		}
+
+		un = findUndefined2SkipLocals(store, s, s.Cond, t)
+		if un != "" {
+			return un
+		}
+
+		un = findUndefinedStmt(store, s, s.Post, t)
+		if un != "" {
+			return un
+		}
+
+		for _, b := range s.Body {
+			un := findUndefinedStmt(store, last, b, t)
+			if un != "" {
+				return un
+			}
+		}
+	case *BranchStmt:
+	case nil:
+		return ""
+	default:
+		panic(fmt.Sprintf("findUndefinedStmt: %T not supported", s))
+	}
+	return ""
+}
+
 func findUndefined2(store Store, last BlockNode, x Expr, t Type) (un Name) {
 	if x == nil {
 		return
@@ -3185,6 +3416,13 @@
 				ct.String()))
 		}
 	case *FuncLitExpr:
+		for _, stmt := range cx.Body {
+			un = findUndefinedStmt(store, cx, stmt, t)
+
+			if un != "" {
+				return
+			}
+		}
 		return findUndefined(store, last, &cx.Type)
 	case *FieldTypeExpr:
 		return findUndefined(store, last, cx.Type)

gnovm/tests/files/closure.gno

@@ -0,0 +1,16 @@
+package main
+
+func main() {
+
+}
+
+var a = func() {
+	b()
+}
+
+var b = func() {
+	a()
+}
+
+// Error:
+// main/files/closure.gno:7:5: constant definition loop with a

gnovm/tests/files/var27.gno

@@ -0,0 +1,80 @@
+package main
+
+func main() {}
+
+var myDep string
+
+var myVar1 = func() {
+	a := myDep1
+}
+
+var myDep1 string
+
+var myVar2 = func() {
+	aaa := ""
+
+	switch myDep {
+	case aaa:
+		println(myDep2)
+	}
+}
+
+var myDep2 string
+
+var myVar3 = func() {
+	for _, c := range myDep3 {
+		println(c)
+	}
+}
+
+var myDep3 string
+
+var v1 = func() int {
+	v2 := 11
+	return v2
+}()
+
+var v2 = func() int {
+	return v1
+}()
+
+var v3 = func() int {
+	return func() int {
+		v4 := 11
+		return v4
+	}()
+}()
+
+var v4 = func() int {
+	return v3
+}()
+
+var v5 = func() int {
+	v6 := 11
+	return func() int {
+		return v6
+	}()
+}()
+
+var v6 = func() int {
+	return v5
+}()
+
+var other = func() {
+	if true {
+		something := 2
+		print(something) // 2
+	} else {
+		print(something) // a string, but single shared 'st' masks the outer/global reference.
+	}
+}
+var something = "a string"
+
+var other1 = func() {
+	if true {
+		something1 := 2
+		print(something1) // 2
+	}
+	print(something1) // a string, but single shared 'st' masks the outer/global reference.
+}
+var something1 = "a string"

gnovm/tests/files/var28.gno

@@ -0,0 +1,18 @@
+package main
+
+func main() {}
+
+var foo = func() (bool, bool) {
+	return true, true
+}
+
+var x = func() bool { return a }()
+var a, b = foo()
+
+var a1 = func() int {
+	type B1 b1
+	x := B1(1)
+	return int(x)
+}
+
+type b1 int