-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: for loop and if #2140
Merged
perf: for loop and if #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-dambovaliev
requested review from
jaekwon,
moul,
piux2 and
deelawn
as code owners
May 17, 2024 13:42
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 54.63% 54.61% -0.02%
==========================================
Files 581 582 +1
Lines 77544 78372 +828
==========================================
+ Hits 42363 42804 +441
- Misses 32023 32358 +335
- Partials 3158 3210 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ltzmaxwell
reviewed
May 19, 2024
ltzmaxwell
reviewed
May 23, 2024
thehowl
reviewed
May 29, 2024
thehowl
reviewed
May 29, 2024
jaekwon
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves this
Benchmarks
By avoiding the runtime type conversion, we can see that we almost doubled the performance of these statements.