fix: custom boolean types in conditional statements

[nettijoe96]

Resolves #1087

Preprocess conditional expr with checkOrConvertBoolType

Unit test for if and for condition and integ test for invalid assignment. The invalid assignment is a case that fails to compile in Go, but succeeded in Gno before this change.

Run tests:

go test -run ^TestRunApp$ github.com/gnolang/gno/gnovm/cmd/gno 
go test -run ^TestFiles$ github.com/gnolang/gno/gnovm/tests

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[thehowl]

Hey, sorry for the wait. I'll take a look today!

[nettijoe96]

Note: currently looking into why go test -timeout 30s -run ^TestFiles$ github.com/gnolang/gno/gnovm/tests is failing

[thehowl]

Note: currently looking into why go test -timeout 30s -run ^TestFiles$ github.com/gnolang/gno/gnovm/tests is failing

It seems like the expression can be nil, like in for loops where the conditional is optional. Let's remove the nil check.

[jaekwon]

checkOrConvertIntegerType calls checkOrConvertType here, I wonder why there is asymmetry, and if we need it.

[jaekwon]

also take a look at this, which I haven't reviewed; it makes changes to dependent functions.
#1426

[nettijoe96]

checkOrConvertIntegerType is calling checkIntegerType here:

gno/gnovm/pkg/gnolang/preprocess.go

Lines 3017 to 3024 in 80c9ddc

	func checkOrConvertIntegerType(store Store, last BlockNode, x Expr) {
	if cx, ok := x.(*ConstExpr); ok {
	convertConst(store, last, cx, IntType)
	} else if x != nil {
	xt := evalStaticTypeOf(store, last, x)
	checkIntegerType(xt)
	}
	}

[nettijoe96]

also take a look at this, which I haven't reviewed; it makes changes to dependent functions. #1426

I think checkType would have to be changed to assertAssignableTo after that PR merges. I added a comment noting this

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.61%. Comparing base (71a298b) to head (552f46f).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2147   +/-   ##
=======================================
  Coverage   54.61%   54.61%           
=======================================
  Files         582      582           
  Lines       78372    78372           
=======================================
  Hits        42801    42801           
  Misses      32360    32360           
  Partials     3211     3211           

Flag	Coverage Δ
gno.land	61.86% <ø> (ø)
gnovm	59.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jaekwon]

thank you! modified to use new functions.