feat: update favicon and og #2148
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
=======================================
Coverage 49.03% 49.03%
=======================================
Files 576 576
Lines 77556 77556
=======================================
Hits 38032 38032
Misses 36438 36438
Partials 3086 3086
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zivkovicmilos
approved these changes
May 20, 2024
moul
approved these changes
May 20, 2024
alexiscolin
added
the
don't merge
moul
approved these changes
May 20, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
May 21, 2024
This PR updates favicon and og images / info. - More favicon formats and sizes (for quality, compatibility and HD matters) - All images have been optimized to reduce their sizes - Adds a default `og` image to improve UX and SEO when users share the website - Completes basic `og` info such as `title` and `description` Note: _Would be cool to use a themed (light/dark) favicon by using native `prefered-color-scheme` in the next `gnoweb` iteration (require to update the light/dark theme system a bit)_ _We could also add a `webmanifest.json`to give more details to android devices (when users install the website as a webapp and/or pin it to their homescreen). Same for IE with a `msImage` and a browserconfig.xml file_
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates favicon and og images / info.
ogimage to improve UX and SEO when users share the websiteoginfo such astitleanddescriptionNote:
Would be cool to use a themed (light/dark) favicon by using native
prefered-color-schemein the nextgnowebiteration (require to update the light/dark theme system a bit)We could also add a
webmanifest.jsonto give more details to android devices (when users install the website as a webapp and/or pin it to their homescreen). Same for IE with amsImageand a browserconfig.xml file