Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve missing config error message #2247

Merged
merged 2 commits into from
May 31, 2024

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented May 30, 2024

If the config file can't be found when running gnoland start, then the error message should tell me how to fix this by running gnoland config init.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@deelawn deelawn requested review from zivkovicmilos and a team as code owners May 30, 2024 19:18
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label May 30, 2024
@deelawn deelawn merged commit edb321f into gnolang:master May 31, 2024
7 checks passed
@deelawn deelawn deleted the feat/improve-missing-config branch May 31, 2024 19:33
DIGIX666 pushed a commit to DIGIX666/gno that referenced this pull request Jun 2, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->
If the config file can't be found when running `gnoland start`, then the
error message should tell me how to fix this by running `gnoland config
init`.
<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->
If the config file can't be found when running `gnoland start`, then the
error message should tell me how to fix this by running `gnoland config
init`.
<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants