Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnoland): fix: wrong help message for balances add #2284

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix(gnoland): fix: wrong help message for balances add #2284

merged 2 commits into from
Jun 7, 2024

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Jun 5, 2024

command is balances add, but help message was for validator add

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@r3v4s r3v4s requested review from zivkovicmilos and a team as code owners June 5, 2024 06:37
@r3v4s r3v4s requested review from leohhhn and harry-hov June 5, 2024 06:37
@r3v4s r3v4s self-assigned this Jun 5, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 5, 2024
@r3v4s r3v4s added 📖 documentation Improvements or additions to documentation and removed 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jun 5, 2024
@adr-sk adr-sk mentioned this pull request Jun 5, 2024
Open
deelawn
deelawn requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Can you make it adds balances to the genesis.json?

@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 7, 2024

Nice catch. Can you make it adds balances to the genesis.json?

7e4e3e9

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 7, 2024
@leohhhn leohhhn mentioned this pull request Jun 7, 2024
Open
7 tasks
@deelawn deelawn merged commit 43b4380 into gnolang:master Jun 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deelawn deelawn deelawn approved these changes

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos zivkovicmilos is a code owner

@leohhhn leohhhn Awaiting requested review from leohhhn

@harry-hov harry-hov Awaiting requested review from harry-hov

Assignees

@r3v4s r3v4s

Labels
📖 documentation Improvements or additions to documentation 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
💪 Bounties & Worx
Status: Done
🤝🏻 Partner: Onbloc
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @deelawn