Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new validator docs (+ updated docs for gnoland cli) #2285

Merged

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Jun 5, 2024

This PR adds the validator docs and updates old gnoland cli docs.
Closes #1820

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@r3v4s r3v4s requested a review from moul as a code owner June 5, 2024 07:54
@r3v4s r3v4s requested review from zivkovicmilos and leohhhn and removed request for moul June 5, 2024 07:54
@r3v4s r3v4s added the 📖 documentation Improvements or additions to documentation label Jun 5, 2024
@r3v4s r3v4s changed the title doc: new validator docs (+ updated docs for gnoland cli) docs: new validator docs (+ updated docs for gnoland cli) Jun 5, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Jun 5, 2024

Thanks for this.

I will take a detailed look soon, but for starters, can you move the validator docs into the gno-infrastructure folder? This folder was added in recently, and is the place for these docs 🙏

@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 5, 2024

Thanks for this.

I will take a detailed look soon, but for starters, can you move the validator docs into the gno-infrastructure folder? This folder was added in recently, and is the place for these docs 🙏

Should I just move validator folder into gno-infrastructure, so final path would be like /docs/gno-infrastructure/validator ??

@leohhhn
Copy link
Contributor

leohhhn commented Jun 10, 2024

I suggest this structure:

docs/
    --gno-infrastructure/
            -----validators/
                ----- overview.md
                ----- running-a-validator.md
                ----- faq.md

Then, we can have the overview.md file be an index page (the page that shows up when you click on a section in the sidebar), and the two dropdowns would be Running a Validator" & "FAQ".

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comments 🙏

I think it's going in a good direction, but we can do even better for the v1 of these docs. Check the comments and let me know what you think

docs/gno-tooling/cli/gnoland.md Show resolved Hide resolved
docs/validator/faq.md Outdated Show resolved Hide resolved
docs/validator/faq.md Outdated Show resolved Hide resolved
docs/validator/faq.md Outdated Show resolved Hide resolved
docs/validator/faq.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
docs/gno-tooling/cli/gnoland.md Outdated Show resolved Hide resolved
@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 10, 2024

I suggest this structure:

docs/
    --gno-infrastructure/
            -----validators/
                ----- overview.md
                ----- running-a-validator.md
                ----- faq.md

Then, we can have the overview.md file be an index page (the page that shows up when you click on a section in the sidebar), and the two dropdowns would be Running a Validator" & "FAQ".

suggestion structure looks better to me. 8a5c5ab

docs/gno-infrastructure/validators/overview.md Outdated Show resolved Hide resolved
docs/gno-infrastructure/validators/running-a-validator.md Outdated Show resolved Hide resolved
docs/gno-infrastructure/validators/running-a-validator.md Outdated Show resolved Hide resolved
docs/gno-infrastructure/validators/running-a-validator.md Outdated Show resolved Hide resolved
docs/validator/validator.md Outdated Show resolved Hide resolved
docs/validator/validator.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
docs/validator/running-a-validator.md Outdated Show resolved Hide resolved
@zivkovicmilos zivkovicmilos merged commit f74e5f0 into gnolang:master Jun 25, 2024
5 checks passed
@zivkovicmilos zivkovicmilos deleted the docs/new-validator-docs-update-gnoland branch June 26, 2024 07:13
zivkovicmilos added a commit that referenced this pull request Jun 26, 2024
## Description

This PR updates the broken styling, links in #2285.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

This PR adds the `validator` docs and updates old `gnoland` cli docs.
Closes gnolang#1820 

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: adr-sk <andrew@onbloc.xyz>
Co-authored-by: Milos Zivkovic <milos.zivkovic@tendermint.com>
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
## Description

This PR updates the broken styling, links in gnolang#2285.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[docs] Create documentation for multinode clusters
5 participants