Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): incorrect Emit signature in stdshim #2292

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Jun 5, 2024

Description

Cherry-picked from here. Fixes the Emit function where it fails in specific cases.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested a review from thehowl as a code owner June 5, 2024 16:07
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jun 5, 2024
@thehowl thehowl merged commit dbfdbf7 into gnolang:master Jun 5, 2024
15 checks passed
@leohhhn leohhhn deleted the fix/stdshim-emit branch June 5, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants