Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gno.land/Makefile): lazily start gnoland node #2293

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

harry-hov
Copy link
Contributor

start.gnoland fails as it requires config, genesis,... to be created manually in order to start the node.

Since this is for development purpose. Let's run gnoland start with -lazy flag.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (dbfdbf7) to head (df06700).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2293   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files         578      578           
  Lines       77877    77877           
=======================================
  Hits        42545    42545           
  Misses      32160    32160           
  Partials     3172     3172           
Flag Coverage Δ
gno.land 61.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltzmaxwell
Copy link
Contributor

do you think autoConfig or something similar is a better name?

It's a mostly a personal preference: lazy init, as an optimization initialization strategy, can be always used as a default. So the form could be like this:

if c.autoConfig{
    initNodeDir()
}

func initNodeDir(){
    if !exists{
        //  init logic
    }
}

@deelawn deelawn merged commit 2e5ac4a into gnolang:master Jun 6, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants