-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the ability to add packages to genesis transactions #2327
Conversation
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only thing I would do is to separate the functionality into two different commands. That will allow us in the future to add more functionality to them related to sheets or packages without needing to fiddle around with functionality that is not fully related.
…olang/gno into dev/zivkovicmilos/genesis-txs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit to avoid a panic, apart from that, LGTM.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2327 +/- ##
==========================================
+ Coverage 54.60% 54.62% +0.01%
==========================================
Files 579 581 +2
Lines 77899 77952 +53
==========================================
+ Hits 42539 42582 +43
- Misses 32191 32196 +5
- Partials 3169 3174 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR introduces the ability to specify a package directory that will recursively be added (deployed) to the
genesis.json
, utilizing the existinggnoland genesis txs add
command.It also separates out the logic from
gnoland genesis txs add
into:gnoland genesis txs add sheets
for individual tx sheet files (ex. from tx-archive output)gnoland genesis txs add packages
for recursively adding packages (ex.examples
)Related:
gnoland start
's genesis generation to cmd/genesis #1952txs generate
andtxs clear
command #1988Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description