-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tm2): Add missing unit tests for tm2/pkg/crypto/client #2350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhpn99
requested review from
gfanton,
zivkovicmilos,
a team and
jaekwon
as code owners
June 13, 2024 10:02
github-actions
bot
added
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
labels
Jun 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
+ Coverage 55.02% 55.17% +0.15%
==========================================
Files 595 595
Lines 79662 79669 +7
==========================================
+ Hits 43832 43960 +128
+ Misses 32514 32384 -130
- Partials 3316 3325 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
🧾 package/realm
Tag used for new Realms or Packages.
📦 🤖 gnovm
Issues or PRs gnovm related
labels
Jul 13, 2024
linhpn99
changed the title
Add missing unit tests for tm2/pkg/crypto/client
feat(tm2): Add missing unit tests for tm2/pkg/crypto/client
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
📦 🤖 gnovm
Issues or PRs gnovm related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #2309
From @moul 's request to add unit tests, I realized there are many code sections (
maketx
,call
,query
, etc.) that are not covered by unit tests. Obviously, this PR is created to address all of them :)Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description