feat(p/ufmt): Support more formatting verbs #2351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
requested review from
thehowl and
ltzmaxwell
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
mvertes
approved these changes
Jun 28, 2024
moul
approved these changes
Jun 29, 2024
Co-authored-by: Marc Vertes <mvertes@free.fr>
thehowl
reviewed
Sep 20, 2024
Comment on lines
+139
to
+148
| switch v := arg.(type) { | ||
| case uint8: | ||
| buf += strconv.FormatUint(uint64(v), 16) | ||
| case []uint8, [32]uint8: | ||
| for _, b := range v { | ||
| buf += strconv.FormatUint(uint64(b), 16) | ||
| } | ||
| default: | ||
| buf += "(unhandled)" | ||
| } |
There was a problem hiding this comment.
this code... isn't supposed to work... https://go.dev/play/p/wzaZ2BdezvX
There was a problem hiding this comment.
yeah ok, it doesn't in gno, either. that's why the build is failing.
thehowl
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for several new formatting verbs to the
ufmtpackage:%x: Outputs byte values as hexadecimal strings. Supports uint8, []uint8, and [32]uint8 types.%c: Outputs characters. Supports rune and int types.%q: Outputs quoted strings with proper escaping. Supports string type.%T: Outputs the type of the value. Supports various built-in types using type switching with interface{}.Particularly in the case of byte slices, previously need to use a loop to convert each element to a string one by one, but now there is no need for that anymore.