-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coverage): Add back coverage support for txtar
#2377
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
==========================================
+ Coverage 54.99% 60.11% +5.11%
==========================================
Files 595 560 -35
Lines 79775 74686 -5089
==========================================
+ Hits 43872 44895 +1023
+ Misses 32581 26400 -6181
- Partials 3322 3391 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
48ee521
to
25678d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like gnovm coverage went down 20%, we have to check why.
@ajnavarro An idea to avoid having |
753b119
to
0db83ab
Compare
@ajnavarro should be good now |
IMO having txtar on its own coverage tag does not makes sense... A tag is defined per module we are testing, not by a group of tests... What is specifically testing txtar? gnovm? tm2? gno node? a mix? |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
67be832
to
bcc4a9a
Compare
i've added filtering by module so it doesn't expand coverage on multiple tags |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Add back coverage support for
txtar
, which was removed during the CI rework.This only includes
txtar
test files fromgnovm
package (not those for gnoland, I will do that in another PR).It adds approximately 5% coverage, which is a non-negligible.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description