Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tm2): OTEL / handle http metrics exporter #2402

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

albttx
Copy link
Member

@albttx albttx commented Jun 20, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@albttx albttx requested review from a team, moul, jaekwon, piux2 and zivkovicmilos as code owners June 20, 2024 12:34
@albttx albttx self-assigned this Jun 20, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 54.67%. Comparing base (25dba01) to head (da5b88f).

Files Patch % Lines
tm2/pkg/telemetry/metrics/metrics.go 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
- Coverage   54.71%   54.67%   -0.04%     
==========================================
  Files         582      581       -1     
  Lines       78414    77260    -1154     
==========================================
- Hits        42901    42241     -660     
+ Misses      32299    31872     -427     
+ Partials     3214     3147      -67     
Flag Coverage Δ
gno.land 62.05% <ø> (ø)
tm2 54.46% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl requested a review from deelawn June 20, 2024 13:52
Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to allow both http and grpc exporters. I have just one comment below about security when using https

tm2/pkg/telemetry/metrics/metrics.go Show resolved Hide resolved
@zivkovicmilos zivkovicmilos enabled auto-merge (squash) June 20, 2024 16:43
@zivkovicmilos zivkovicmilos merged commit ea1ff3f into master Jun 20, 2024
76 of 78 checks passed
@zivkovicmilos zivkovicmilos deleted the telemetry-http branch June 20, 2024 16:52
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants