Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Implement sponsors (p+r) for sponsor service management #2411

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jun 21, 2024

From Proposal #2152 :

SponsorTransaction_Flow (3)

  • This PR proposes a new realm specifically for managing information related to sponsor services. This information will be readily accessible to dApps (decentralized applications) within the ecosystem
  • Please note that the realm's functionalities are currently limited for demonstration purposes. We are actively working on further development and will introduce additional features in the future

Related Pull Requests:

  1. feat(gnoland): Define NoopMsg to facilitate the creation of sponsor transaction (gasless transaction) #2209: This pull request define new noopMsg
  2. feat(gnoland): Define and implement SponsorTransaction concept #2630: This pull request enhances the gnoclient by introducing the ability to create and send a sponsor transaction through the definition of a noopMsg
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from a team as code owners June 21, 2024 07:27
@linhpn99 linhpn99 requested review from jaekwon and piux2 and removed request for a team June 21, 2024 07:27
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 21, 2024
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting idea, but we need to address the non-realm aspect of the sponsorship before tackling this. I'll mark this PR as a draft with changes requested until we delve deeper into the other part. Thank you.

@moul moul marked this pull request as draft July 3, 2024 23:36
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (0e3c050) to head (4b2f51c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2411   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         595      595           
  Lines       79775    79775           
=======================================
+ Hits        43872    43876    +4     
+ Misses      32581    32579    -2     
+ Partials     3322     3320    -2     
Flag Coverage Δ
contribs/gnodev 26.00% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 64.15% <ø> (ø)
gnovm 60.20% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.46% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants