fix(gnovm): Resolve RefValues before using as Objects #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deelawn
requested review from
jaekwon,
moul,
piux2,
thehowl and
mvertes
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2454 +/- ##
==========================================
+ Coverage 54.68% 54.80% +0.12%
==========================================
Files 583 583
Lines 78503 79124 +621
==========================================
+ Hits 42928 43364 +436
- Misses 32368 32486 +118
- Partials 3207 3274 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mvertes
reviewed
Jun 28, 2024
mvertes
approved these changes
Jun 28, 2024
jaekwon
reviewed
Jul 1, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
Closes gnolang#2449. I believe the bug was introduced by gnolang#2255. Previously, if the type of `tv.V` in `GetFirstObject` was a `PointerValue`, it the `Base` would have been nil in the scenario producing this bug. Now that `Base` can never be nil for a `PointerValue`, the nil base check has been removed. We do however need to account for a new scenario where the `Base` is a `RefValue`, a type that does implement the `Object` interface. In the case where the base is a `RefValue`, first resolve it by calling `store.GetObject`. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2449.
I believe the bug was introduced by #2255. Previously, if the type of
tv.VinGetFirstObjectwas aPointerValue, it theBasewould have been nil in the scenario producing this bug. Now thatBasecan never be nil for aPointerValue, the nil base check has been removed. We do however need to account for a new scenario where theBaseis aRefValue, a type that does implement theObjectinterface. In the case where the base is aRefValue, first resolve it by callingstore.GetObject.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description