fix(gnoweb): footer display #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2462 +/- ##
==========================================
- Coverage 54.92% 54.73% -0.19%
==========================================
Files 594 586 -8
Lines 79297 78577 -720
==========================================
- Hits 43550 43007 -543
+ Misses 32456 32352 -104
+ Partials 3291 3218 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alexiscolin
approved these changes
Jul 7, 2024
leohhhn
approved these changes
Jul 7, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
I noticed the footer was not taking its whole height in certain pages Example: ([r/demo/banktest?help](https://gno.land/r/demo/banktest?help))  After this PR:  The solution seems to be changing the footer's css to `inline-block` display instead of `block` <details><summary>Contributors' checklist...</summary> - [X] Added new tests, or not needed, or not feasible - [X] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [X] Updated the official documentation or not needed - [X] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the footer was not taking its whole height in certain pages
Example: (r/demo/banktest?help)
After this PR:
The solution seems to be changing the footer's css to
inline-blockdisplay instead ofblockContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description