Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set go version to 1.22.4 on mod files. #2474

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Jul 1, 2024

If we do not specify a correct toolchain Go was failing with the following error:

go: downloading go1.22 (linux/amd64)
go: download go1.22 for linux/amd64: toolchain not available

@ajnavarro ajnavarro changed the title Set go version to 1.22.4 on mod files. fix: Set go version to 1.22.4 on mod files. Jul 1, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.70%. Comparing base (e282618) to head (b9f45b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2474   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         583      583           
  Lines       78504    78504           
=======================================
+ Hits        42945    42947    +2     
+ Misses      32350    32349    -1     
+ Partials     3209     3208    -1     
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.54% <ø> (ø)
gnovm 59.97% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (-0.31%) ⬇️
misc/loop 0.00% <ø> (ø)
tm2 54.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If we do not specify a correct toolchain Go was failing with the following error:

go: downloading go1.22 (linux/amd64)
go: download go1.22 for linux/amd64: toolchain not available

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the fix/go-version-mod-files branch from f37e3af to b9f45b3 Compare July 1, 2024 14:33
@ajnavarro ajnavarro requested a review from thehowl July 1, 2024 14:34
@thehowl thehowl merged commit 79a71a4 into master Jul 1, 2024
109 checks passed
@thehowl thehowl deleted the fix/go-version-mod-files branch July 1, 2024 19:22
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
If we do not specify a correct toolchain Go was failing with the
following error:

go: downloading go1.22 (linux/amd64)
go: download go1.22 for linux/amd64: toolchain not available

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants