chore(gnodev): show link to docs upon 'h' key #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2497 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 590 590
Lines 79036 79036
=======================================
Hits 43230 43230
Misses 32554 32554
Partials 3252 3252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gfanton
reviewed
Jul 4, 2024
|
Updated, following recommandations:
NoteIf we get shorter links after #2262 perhaps in the future this could be used:
The red vertical shows the 80 cols and as you can see the line holds within the limit. |
grepsuzette
commented
Jul 4, 2024
leohhhn
approved these changes
Jul 4, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
I propose we have "h" commandin gnodev mention a link to the full help of gnodev. This is a possible implementation. Tried a few variants, this one seems simple enough:  @gfanton feel free to suggest changes :) --------- Co-authored-by: grepsuzette <grepsuzette@users.noreply.github.com> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose we have "h" commandin gnodev mention a link to the full help of gnodev. This is a possible implementation.
Tried a few variants, this one seems simple enough:
@gfanton feel free to suggest changes :)