-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test4 genesis.json
and suggested config.toml
#2508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2508 +/- ##
=======================================
Coverage 55.02% 55.02%
=======================================
Files 595 595
Lines 79645 79645
=======================================
+ Hits 43824 43827 +3
+ Misses 32503 32500 -3
Partials 3318 3318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just be to sure, is this suggestion stands for..
or something else? |
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
IMPORTANT You can view the genesis transactions that differ from the |
## Description This PR adds the **test4** `genesis.json` and suggested `config.toml`. It also includes a relevant README to highlight important `config.toml` params.⚠️ **IMPORTANT**⚠️ You can view the genesis transactions that differ from the examples folder here: gnolang/gno@dev/zivkovicmilos/test4-genesis...dev/zivkovicmilos/test4-genesis-prepared In case anyone is curious, I extracted the bech32 representation of the public keys from the `genesis.json` using this script: ```go package main import ( "fmt" _ "github.com/gnolang/gno/gno.land/pkg/gnoland" "github.com/gnolang/gno/tm2/pkg/bft/types" ) func main() { path := "../gno/misc/deployments/test4.gno.land/genesis.json" doc, err := types.GenesisDocFromFile(path) if err != nil { panic(err) } for _, v := range doc.Validators { fmt.Printf("Name: %s\n", v.Name) fmt.Printf("Address: %s\n", v.Address) fmt.Printf("PubKey: %s\n", v.PubKey.String()) fmt.Printf("\n===========================\n\n") } } ``` <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Salvatore Mazzarino <salvatore.mazzarino@tendermint.com> Co-authored-by: Blake <104744707+r3v4s@users.noreply.github.com>
Description
This PR adds the test4
genesis.json
and suggestedconfig.toml
.It also includes a relevant README to highlight important
config.toml
params.You can view the genesis transactions that differ from the examples folder here:
dev/zivkovicmilos/test4-genesis...dev/zivkovicmilos/test4-genesis-prepared
In case anyone is curious, I extracted the bech32 representation of the public keys from the
genesis.json
using this script:Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description