Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add r/grc20reg #2516

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

feat: add r/grc20reg #2516

wants to merge 71 commits into from

Conversation

moul
Copy link
Member

@moul moul commented Jul 5, 2024 •
edited
Loading

Continues #1072
Related #1275, #1262
Depends on #1257
Depends on #2551

n0izn0iz and others added 12 commits August 25, 2023 20:48
@n0izn0iz
feat: grc20 registry
8a5ecbc 
Signed-off-by: Norman Meier <norman@berty.tech>
@jaekwon
initial commit of receiver implied realm for pkg methods
9c5fcde
@jaekwon
deref receiver before checking if object
a9bee16
@jaekwon
...
bc47c25
@jaekwon
...
ec4d717
@jaekwon
add realmtest
75b1d10
@moul
Merge remote-tracking branch 'origin/master' into grc20_registry
86235c7
@moul
feat: add p/demo/fqname
60162b9 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
feat: add fqname.RenderLink
621a877 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: refactor grc20_registry
e545bfb 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: rename grc20reg
cdbe6da 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: emit event on registration
a65537b 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 5, 2024
@moul moul mentioned this pull request Jul 5, 2024
Closed
7 tasks
moul added 2 commits July 5, 2024 14:24
@moul
chore: fixup
e8668f0 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
Merge remote-tracking branch 'origin/dev/jae/boundmethodrealm' into d…
e1a79fe 
…ev/moul/grc20reg
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.81%. Comparing base (9897b66) to head (aaa5922).

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/machine.go 63.15% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2516      +/-   ##
==========================================
- Coverage   60.87%   58.81%   -2.06%     
==========================================
  Files         563      560       -3     
  Lines       75193    74731     -462     
==========================================
- Hits        45770    43955    -1815     
- Misses      26055    27459    +1404     
+ Partials     3368     3317      -51
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul changed the title feat: grc20 registry feat: add r/grc20reg + p/fqname Jul 5, 2024
@moul
chore: fixup
3f83d01 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
jaekwon and others added 19 commits July 7, 2024 10:54
@jaekwon
optimized fix
00a2779
@moul
Merge remote-tracking branch 'origin/dev/jae/crossrealm' into dev/mou…
ff894be 
…l/boundbug
@moul
Merge remote-tracking branch 'origin/dev/jae/crossrealm' into dev/mou…
9aa33e4 
…l/grc20reg
@jaekwon
optimize
3a498f6
@moul
Merge remote-tracking branch 'origin/dev/jae/crossrealm' into dev/mou…
5ebf68f 
…l/grc20reg
@jaekwon
add test for crossrealm new escaped internal objects
60b99cc
@moul
Merge remote-tracking branch 'origin/dev/jae/crossrealm' into dev/mou…
ebd2f44 
…l/grc20reg
@moul
Merge remote-tracking branch 'origin/dev/jae/crossrealm' into dev/mou…
5eb4447 
…l/boundbug
@moul
chore: fixup
03e838b 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: fixup
71b74f4 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: fixup
4ca57af 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
Merge branch 'dev/moul/boundbug' into dev/moul/grc20reg
df5df54
@jaekwon
change realm to receiver's
a91c84a
@moul
Merge remote-tracking branch 'origin/dev/jae/crossrealm' into dev/mou…
90034b9 
…l/grc20reg
@moul
Merge branch 'master' into dev/moul/grc20reg
90bee8b
@moul
chore: fixup
f48048b 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: fixup
9073056 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
chore: fixup
67e5353 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
Merge branch 'master' into dev/moul/grc20reg
3b906ad
@moul moul mentioned this pull request Jul 9, 2024
Draft
@Kouteki Kouteki mentioned this pull request Jul 22, 2024
Open
@moul
Copy link
Member Author

moul commented Aug 29, 2024 •
edited
Loading

Blocked by #2743

@moul moul mentioned this pull request Sep 17, 2024
Merged
7 tasks
thehowl added a commit that referenced this pull request Sep 18, 2024
@moul @thehowl
feat(examples): add p/fqname (#2808)
01ee5a9 
Extracted from #2551 (also #2516).

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Morgan <git@howl.moe>
@moul moul changed the title feat: add r/grc20reg + p/fqname feat: add r/grc20reg Sep 21, 2024
@r3v4s
Copy link
Contributor

r3v4s commented Oct 27, 2024

First of all, I know that this pr is sill working in progress, but couldn't wait for charming of supporting multiple grc20 tokens by default in gno-eco system(in this case grc20reg) and did some test.

Currently, grc20reg takes object from other realm to register it, and it seems like affects stack-frame. (tested with _test.gno)

On the other hand, testing with txtar slightly returns different result, cannot modify external-realm or non-realm object.
Is this due to #2743 you mentioned blocked by ??

@moul
Copy link
Member Author

moul commented Oct 27, 2024

Yes, this grc20reg is no longer a work in progress, but it depends on the changes in the PR, specifically those in #2743.

For a preview of fully working examples, you can check my meta PR #2551, which includes some VM fixes, this completed realm, and other realms that use it, such as the atomicswap realm, for instance.

@n0izn0iz n0izn0iz mentioned this pull request Oct 31, 2024
Open
@r3v4s r3v4s mentioned this pull request Nov 3, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moul moul

Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: No status
😎 Manfred's Board
Status: 🎯 Current Topics
🧙‍♂️gno.land core team
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moul @r3v4s @n0izn0iz @jaekwon