-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tm2): Fix the endpoint /tx?hash= to make it work #2518
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2518 +/- ##
==========================================
+ Coverage 60.44% 62.98% +2.54%
==========================================
Files 563 567 +4
Lines 75159 82601 +7442
==========================================
+ Hits 45427 52026 +6599
- Misses 26343 27112 +769
- Partials 3389 3463 +74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some work to be done for a proper fix.
c9fe0c8
to
b4b9b2d
Compare
Removed the "review team" label because this is already reviewed by core devs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to be convinced of a few things, so cloned and tested it out. I committed some clarifications, but it looks good overall.
cc/ @zivkovicmilos for a final review.
From issue : #2489
I found an issue with the code segment parsing arguments from the request that did not support base64 encoding, so I implemented logic to handle it. If there are any inconsistencies, please share the opinion
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description