Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tm2): Fix the endpoint /tx?hash= to make it work #2518

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jul 6, 2024

From issue : #2489

I found an issue with the code segment parsing arguments from the request that did not support base64 encoding, so I implemented logic to handle it. If there are any inconsistencies, please share the opinion

Screenshot from 2024-07-06 12-00-09

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.98%. Comparing base (f04ec89) to head (9f13812).
Report is 90 commits behind head on master.

Files with missing lines Patch % Lines
tm2/pkg/bft/rpc/lib/server/handlers.go 64.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2518      +/-   ##
==========================================
+ Coverage   60.44%   62.98%   +2.54%     
==========================================
  Files         563      567       +4     
  Lines       75159    82601    +7442     
==========================================
+ Hits        45427    52026    +6599     
- Misses      26343    27112     +769     
- Partials     3389     3463      +74     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (-0.89%) ⬇️
contribs/gnofaucet 15.77% <ø> (+0.45%) ⬆️
gno.land 67.37% <ø> (+0.15%) ⬆️
gnovm 67.36% <ø> (+2.89%) ⬆️
misc/genstd 79.72% <ø> (-0.83%) ⬇️
tm2 62.45% <64.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linhpn99 linhpn99 changed the title fix(tm2): Fix the endpoint /tx?hash= so that it is usable fix(tm2): Fix the endpoint /tx?hash= to make it work Jul 6, 2024
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some work to be done for a proper fix.

tm2/pkg/bft/rpc/lib/server/handlers.go Show resolved Hide resolved
@linhpn99 linhpn99 requested a review from thehowl July 7, 2024 16:06
tm2/pkg/bft/rpc/lib/server/handlers.go Outdated Show resolved Hide resolved
tm2/pkg/bft/rpc/lib/server/handlers.go Outdated Show resolved Hide resolved
@leohhhn
Copy link
Contributor

leohhhn commented Sep 11, 2024

#2333 (comment)

@Kouteki Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 4, 2024
@jefft0
Copy link
Contributor

jefft0 commented Oct 4, 2024

Removed the "review team" label because this is already reviewed by core devs.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to be convinced of a few things, so cloned and tested it out. I committed some clarifications, but it looks good overall.

cc/ @zivkovicmilos for a final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

5 participants