Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Dev/jae/crossrealm #2535

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

WIP Dev/jae/crossrealm #2535

wants to merge 8 commits into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Jul 7, 2024

Fixing crossrealm pointer persistence issues.

go run github.com/gnolang/gno/gnovm/cmd/gno test -v --update-golden-tests --print-runtime-metrics ./examples/gno.land/r/demo/foo20

Addresses #2526

@jaekwon jaekwon requested review from thehowl, moul, piux2, deelawn, mvertes and a team as code owners July 7, 2024 16:54
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/realm.go 35.29% 9 Missing and 2 partials ⚠️
gnovm/pkg/gnolang/machine.go 68.42% 3 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@jaekwon jaekwon force-pushed the dev/jae/crossrealm branch from 8014a85 to a91c84a Compare July 7, 2024 23:06
@moul moul added the don't merge Please don't merge this functionality temporarily label Jul 8, 2024
@moul moul mentioned this pull request Jul 9, 2024
@moul moul marked this pull request as draft August 28, 2024 17:22
@moul
Copy link
Member

moul commented Aug 28, 2024

@moul
Copy link
Member

moul commented Aug 29, 2024

Blocked by #2743

@Kouteki Kouteki removed request for a team and deelawn November 21, 2024 03:34
Copy link

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added Stale and removed Stale labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants