Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt #2546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jul 8, 2024

Description

Removes the usage of the deprecated ast.Object type and replaces it with ast.Ident. Since ast.Ident contains name and location information, I think it would provide the information that needed in most cases.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.91%. Comparing base (8ddf0d8) to head (8ba0d1a).

Files Patch % Lines
gnovm/pkg/gnofmt/processor.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
- Coverage   54.91%   54.91%   -0.01%     
==========================================
  Files         594      594              
  Lines       79297    79297              
==========================================
- Hits        43549    43547       -2     
- Misses      32458    32459       +1     
- Partials     3290     3291       +1     
Flag Coverage Δ
contribs/gnodev 23.53% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 63.14% <ø> (ø)
gnovm 60.21% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon changed the title Chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt Jul 8, 2024
@moul moul requested a review from gfanton July 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants