-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tm2): Implement Basic Authentication in HTTP Client #2590
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2590 +/- ##
==========================================
+ Coverage 60.44% 60.46% +0.02%
==========================================
Files 563 563
Lines 75159 75171 +12
==========================================
+ Hits 45427 45450 +23
+ Misses 26343 26332 -11
Partials 3389 3389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this until I give a detailed review -- I'm not convinced think this is the way to go
From #2450
This PR:
http.Client
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description