-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): handle non call expression valuedecl values #2647
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
+ Coverage 60.14% 60.16% +0.02%
==========================================
Files 560 561 +1
Lines 74738 75507 +769
==========================================
+ Hits 44950 45431 +481
- Misses 26400 26663 +263
- Partials 3388 3413 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok; i still think the problem is that we should not have different code for AssignStmt.DECL and DeclStmt. but it's fine to fix the issue directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
Closes #2636.
With a value declaration like
var a, b = ...
, we currently only support a call expression on the RHS. This PR supports type assertion and index expressions as well.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description