Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timezone location support #2705

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented Aug 15, 2024

Closes #2688.

The PR adds support for timezone locations by embedding an IANA timezone database that gets loaded into memory when gno.land is started. The gno stdlib's time package has been updated by porting over code from the go stdlib to support locations.

This feature allows users to create time instances with locations to ensure that temporal adjustments result in accurate results by following both historical rules and current rules.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.18%. Comparing base (25f1c92) to head (b6c08ce).
Report is 3 commits behind head on master.

Files Patch % Lines
gnovm/stdlibs/time/tzdata.go 77.27% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
+ Coverage   60.15%   60.18%   +0.02%     
==========================================
  Files         561      562       +1     
  Lines       74999    75524     +525     
==========================================
+ Hits        45117    45455     +338     
- Misses      26505    26674     +169     
- Partials     3377     3395      +18     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 64.75% <ø> (ø)
gnovm 64.44% <86.48%> (+0.31%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 62.05% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

Add timezone support to the gno standard library's time package
2 participants