Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bug): In TestAdvancedKeyManagement, check if can get the imported key by address #2718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Aug 21, 2024

This PR demonstrates a bug. TestAdvancedKeyManagement makes an in-memory Keybase, creates a key and tests Export and Import. It appears that Import sets the lookup by name, but not lookup by address. To demonstrate, this PR makes a new in-memory Keybase, imports the same key, and does GetByName to show a successful import. Then it does GetByAddress which should succeed but it fails.

…y by address

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (04d5239) to head (6fd2289).
Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2718   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files         562      562           
  Lines       75091    75091           
=======================================
+ Hits        45230    45233    +3     
+ Misses      26481    26478    -3     
  Partials     3380     3380           
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (ø)
gno.land 64.76% <ø> (ø)
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kouteki Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@jefft0 jefft0 removed request for a team, jaekwon and moul November 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants