Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add p/printfdebugging #2809

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

moul
Copy link
Member

@moul moul commented Sep 17, 2024

Extracted from #2551.

See #2551 (comment).

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Sep 17, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 17, 2024
@moul moul mentioned this pull request Sep 17, 2024
@moul moul marked this pull request as ready for review September 17, 2024 17:18
@moul moul requested review from a team as code owners September 17, 2024 17:18
@moul moul requested review from ajnavarro and piux2 and removed request for a team September 17, 2024 17:18
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (5503cca) to head (2bc08cb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
+ Coverage   60.83%   60.87%   +0.04%     
==========================================
  Files         563      563              
  Lines       75193    75235      +42     
==========================================
+ Hits        45743    45802      +59     
+ Misses      26076    26067       -9     
+ Partials     3374     3366       -8     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.17% <ø> (ø)
gnovm 65.63% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 62.07% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is silly, until it isn't

Do you think it makes more sense maybe under p/moul?

Signed-off-by: moul <94029+moul@users.noreply.github.com>
@thehowl thehowl merged commit 35152a6 into master Sep 20, 2024
119 checks passed
@thehowl thehowl deleted the dev/moul/printfdebugging branch September 20, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants