Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strings.Replacer structure on native libraries #2816

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

Villaquiranm
Copy link
Contributor

prerequisite of #2802

This pull request ports the files:

  • replace.go
  • replace_test.go

from the Golang standard library.

I added some tags on the code with the hope it will help to review the code and to launch discussion if neccessary.
I could after remove these changes

// Custom code: XXX_Some_Explanation
( code not present on the original go file)
.
.
.
// End of custom code
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (01ee5a9) to head (b31ccc2).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
+ Coverage   60.84%   61.03%   +0.18%     
==========================================
  Files         563      564       +1     
  Lines       75190    75434     +244     
==========================================
+ Hits        45753    46039     +286     
+ Misses      26068    26009      -59     
- Partials     3369     3386      +17     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (+0.81%) ⬆️
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 67.92% <ø> (+0.75%) ⬆️
gnovm 65.77% <ø> (+0.13%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.06% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member

thehowl commented Sep 20, 2024

I added some tags on the code with the hope it will help to review the code and to launch discussion if neccessary.
I could after remove these changes

more than these tags, which are still good, i'm looking for tooling which can help us compare go stdlibs and gno stdlibs

there was a pr by an external contributor which was stopped at one point: #1425

if you want, you can continue his work, minding the unaddressed comments i made - i'd highly appreciate it ;)

@Villaquiranm
Copy link
Contributor Author

I added some tags on the code with the hope it will help to review the code and to launch discussion if neccessary.
I could after remove these changes

more than these tags, which are still good, i'm looking for tooling which can help us compare go stdlibs and gno stdlibs

there was a pr by an external contributor which was stopped at one point: #1425

if you want, you can continue his work, minding the unaddressed comments i made - i'd highly appreciate it ;)

Sure I would like to take a look @thehowl 👍

@thehowl thehowl merged commit a2b4d4b into gnolang:master Oct 2, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants