-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): prevent assignment to non-assignable expressions #2896
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
- Coverage 63.32% 63.12% -0.21%
==========================================
Files 548 548
Lines 78511 80213 +1702
==========================================
+ Hits 49719 50636 +917
- Misses 25438 26171 +733
- Partials 3354 3406 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
should share some logic with this: #1946 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @ltzmaxwell please do merge after you're satisfied with the feedback
closes: #2889
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description