-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p/json): optimize json #2939
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2939 +/- ##
==========================================
- Coverage 63.09% 62.93% -0.16%
==========================================
Files 563 568 +5
Lines 79273 82371 +3098
==========================================
+ Hits 50015 51843 +1828
- Misses 25893 27081 +1188
- Partials 3365 3447 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @notJoon. Maybe it's obvious to people familiar with the code, but in the description can you put a short explanation why you removed the eisel_lemire and ryu folders? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is follow-on PR by the same author of the original package in #1415 . On my macOS, all tests pass with make test.components
. Removed the review/triage-pending
label. Ready for review by core devs.
description updated. thanks! |
BTW the benchmarks are in go and are likely to mean very little in Gno ;) At most, use |
Description
Optimized the JSON package and simplified JSON node creation using the builder pattern.
buffer.gno
andescape.gno
files are modified the use of map for lookup tables to use slice array instead.Unquote
function inescape.gno
filestrconv
package, and deleted related files and functionseisel_lemire
andryu
packages were deleted since they were files that had been added to handleParseUint
andParseFloat
instrconv
package.JSON Generate Example
Plain JSON
Nested Structure
Benchmark Result for Unquote
Before
After