feat(examples): grc20 refactor #2983
Conversation
Signed-off-by: moul <94029+moul@users.noreply.github.com>
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2983 +/- ##
=======================================
Coverage 63.76% 63.76%
=======================================
Files 548 548
Lines 78681 78681
=======================================
+ Hits 50171 50172 +1
- Misses 25128 25129 +1
+ Partials 3382 3380 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
requested review from
jaekwon and
gfanton
and removed request for
a team
|
cc @MikaelVallenet @n0izn0iz, any thoughts? |
looks good to me, i like the teller pattern & add metadata in token level instead of ledger/bank |
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
This reverts commit 007a2ac.
…into dev/moul/grc20-refacto
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
|
@leohhhn do you want to update the doc in this PR or in your big refactor? |
There was a problem hiding this comment.
LGTM; I feel like showcases and more examples will come after we merge this PR.
I'll also port my constant product dex example afterwards.
As for the doc, I can push changes to your branch here to update it, or make a PR when we merge this. Let me know how you want to go about it.
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
This PR extracts the grc20 refactor from #2551, which is a meta PR containing several contract improvements and additions that depend on new Gnovm features that haven't been merged yet.
Please review this grc20 refactor with a focus on its API. Several valuable comments can be found in #2551. Additionally, you can discover new contracts using grc20 in #2551, such as
minidex,atomicswap,grc20reg,test20, andvault.Addresses #1832