Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "fix(portal-loop): hotfix revert "chore: rename r/manfred -> r/moul (#2820)" (#2865)" #3024

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

moul
Copy link
Member

@moul moul commented Oct 25, 2024

This reverts commit 69400d4.

Revertception.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@moul moul self-assigned this Oct 25, 2024
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

moul-bot pushed a commit to gnolang/tx-exports that referenced this pull request Oct 25, 2024
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
Copy link
Member Author

moul commented Nov 6, 2024

@zivkovicmilos, do you agree that we can merge things here, then merge them on txports, and expect the portal loop to read the history from GitHub?

@moul moul marked this pull request as ready for review November 6, 2024 20:17
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@Kouteki Kouteki added the don't merge Please don't merge this functionality temporarily label Nov 13, 2024
@zivkovicmilos
Copy link
Member

@moul

I've updated the code in this branch to match master

@zivkovicmilos zivkovicmilos removed the don't merge Please don't merge this functionality temporarily label Nov 25, 2024
@zivkovicmilos zivkovicmilos merged commit a723673 into gnolang:master Nov 25, 2024
101 checks passed
zivkovicmilos added a commit to gnolang/tx-exports that referenced this pull request Nov 25, 2024
* chore: fixes for gnolang/gno#3024

Signed-off-by: moul <94029+moul@users.noreply.github.com>

* chore: fixup

Signed-off-by: moul <94029+moul@users.noreply.github.com>

* chore: fixup

Signed-off-by: moul <94029+moul@users.noreply.github.com>

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Miloš Živković <milos.zivkovic@tendermint.com>
n0izn0iz pushed a commit to n0izn0iz/gno that referenced this pull request Nov 26, 2024
…ed -> r/moul (gnolang#2820)" (gnolang#2865)" (gnolang#3024)

This reverts commit 69400d4.

Revertception.

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Miloš Živković <milos.zivkovic@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants