Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gnovm): forbid importing realms in packages #3042

Merged
merged 61 commits into from
Nov 26, 2024
Merged

feat(gnovm): forbid importing realms in packages #3042

merged 61 commits into from
Nov 26, 2024

Conversation

MikaelVallenet
Copy link
Member

@MikaelVallenet MikaelVallenet commented Oct 28, 2024 •
edited
Loading

Closes #3040
50% of the work comes from @harry-hov's PR #1393 (let's repay to Caesar what belongs to Caesar) 🚀

Notable additions:

  • handle different domains (e.g github.com/p/demo/...)
  • skip non .gno files (LICENSE, README, ...) or empty files
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 29, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 29, 2024
@MikaelVallenet
chore: run gno mod tidy
d2f0200
@MikaelVallenet
fix: remove call from realm into pkg demo/test
7b026d1
@MikaelVallenet
test: add txtar testfile to import realm into pkg
e26a293
@MikaelVallenet
fix: remove testfile about realm to pkg import
91aa244
@MikaelVallenet
fix: adapt zrealm_crossrealm11 test to new import restriction
794b5a9
@MikaelVallenet
fix: txtar prevrealm & import realm into pkg
a54975d
@MikaelVallenet
fix: txtat import realm pkg
da09313
@MikaelVallenet
fix: trying to fix txtar test
d52969c
@MikaelVallenet
fix: remove txtar not working test file
eccc2e4
@MikaelVallenet
fix: add test import about pkg importing realm not working
a0fc9f6
@MikaelVallenet
fix: add test import about pkg importing realm not working
0fc525c
@MikaelVallenet
fix: add test import about pkg importing realm not working
49828e8
@MikaelVallenet
fix: add test import about pkg importing realm not working
9af0e68
@MikaelVallenet
fix: add test import about pkg importing realm not working
5459c2d
@MikaelVallenet
fix: add test import about pkg importing realm not working
c92d714
@ltzmaxwell
Copy link
Contributor

ltzmaxwell commented Nov 18, 2024 •
edited
Loading

LGTM, if the CI failing is not relevant with this PR, we can merge it. cc: @thehowl

@ltzmaxwell
Copy link
Contributor

@MikaelVallenet can you please check the CI?

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 19, 2024
@Kouteki Kouteki added this to the 🚀 Mainnet launch milestone Nov 19, 2024
thehowl
thehowl approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good after changes

gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
n0izn0iz
n0izn0iz suggested changes Nov 20, 2024
View reviewed changes
gnovm/pkg/gnolang/helpers.go Outdated Show resolved Hide resolved
@MikaelVallenet MikaelVallenet marked this pull request as draft November 20, 2024 15:12
@MikaelVallenet MikaelVallenet force-pushed the dev/mikaelvallenet/forbid-importing-realms branch from bcbcffa to af320de Compare November 22, 2024 14:38
@MikaelVallenet MikaelVallenet marked this pull request as ready for review November 22, 2024 14:46
n0izn0iz
n0izn0iz approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikaelVallenet
Copy link
Member Author

MikaelVallenet commented Nov 25, 2024 •
edited
Loading

@thehowl does it looks good to merge ? (we spoke about not using the prefix cause some issues with MsgRun tx for now)

thehowl
thehowl reviewed Nov 26, 2024
View reviewed changes
gnovm/pkg/gnolang/helpers.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Show resolved Hide resolved
@Kouteki Kouteki removed the request for review from ltzmaxwell November 26, 2024 14:17
@thehowl thehowl merged commit 4004ba1 into gnolang:master Nov 26, 2024
98 checks passed
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 29, 2024
@gnolang gnolang deleted a comment from Gno2D2 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leohhhn leohhhn leohhhn left review comments

@ltzmaxwell ltzmaxwell ltzmaxwell left review comments

@thehowl thehowl thehowl approved these changes

@omarsy omarsy omarsy approved these changes

@n0izn0iz n0izn0iz n0izn0iz approved these changes

Assignees

@MikaelVallenet MikaelVallenet

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: Done
🧙‍♂️gno.land core team
Status: Done
Milestone
🚀 Mainnet launch
Development

Successfully merging this pull request may close these issues.

forbid importing realms from pure packages (r/ from p/)
8 participants
@MikaelVallenet @jefft0 @n0izn0iz @ltzmaxwell @thehowl @omarsy @leohhhn @Kouteki