Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): upgradable realm demo #3147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mconcat
Copy link

@mconcat mconcat commented Nov 18, 2024

Added upgradable realm demo.

  • admin: main entrypoint for users and controller contract for store and logic
  • store: persistent storage layer across migration steps
  • logic: switchable logic implementation
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 18, 2024
@mconcat mconcat changed the title Upgradable realm demo chore(demo): upgradable realm demo Nov 18, 2024
@dongwon8247
Copy link
Member

It's our initial approach to tackle to the upgradable realm feature. Please have a look. @moul @zivkovicmilos @Kouteki

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@@ -0,0 +1,15 @@
package admin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consolidate all the upgrade demos in one location, and use distinctive names. If you'd like, I can move my other demos to a different folder. Ideally, we should also maintain a shared README that outlines the differences in each implementation; I believe I have already created one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moul @mconcat How about we move this PR to https://github.com/gnolang/gno/tree/master/examples/gno.land/r/x/manfred_upgrade_patterns for now as upgrade_g, and share the same README until we reach an agreement on the upgradable pattern for mainnet? Once finalized, we can move the final one to https://github.com/gnolang/gno/tree/master/examples/gno.land/r/demo.

Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. will approve after this implementation integrated with other ones.

examples/gno.land/r/demo/upgradable/admin/logic.gno Outdated Show resolved Hide resolved
@mconcat
Copy link
Author

mconcat commented Nov 24, 2024

Moved to manfred_upgrade_patterns folder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants