-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(demo): upgradable realm demo #3147
base: master
Are you sure you want to change the base?
chore(demo): upgradable realm demo #3147
Conversation
It's our initial approach to tackle to the upgradable realm feature. Please have a look. @moul @zivkovicmilos @Kouteki |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
@@ -0,0 +1,15 @@ | |||
package admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consolidate all the upgrade demos in one location, and use distinctive names. If you'd like, I can move my other demos to a different folder. Ideally, we should also maintain a shared README that outlines the differences in each implementation; I believe I have already created one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moul @mconcat How about we move this PR to https://github.com/gnolang/gno/tree/master/examples/gno.land/r/x/manfred_upgrade_patterns for now as upgrade_g
, and share the same README until we reach an agreement on the upgradable pattern for mainnet? Once finalized, we can move the final one to https://github.com/gnolang/gno/tree/master/examples/gno.land/r/demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. will approve after this implementation integrated with other ones.
Moved to manfred_upgrade_patterns folder! |
Added upgradable realm demo.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description