feat: allow current pkg access to bank #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
reviewed
Nov 29, 2022
moul
changed the title
Closed
|
Hey @giansalex, Can you please update this branch to the latest @moul What are some of the cons you see? |
|
My concern is about #473, where we're here changing from one mode to another, and I'm looking for a finale solution that's flexible and with sane defaults. |
|
Could someone add unit tests on this PR? one that shows the new usage and one that shows that the previous one does not work anymore, please? |
|
Please share your thoughts on PR #683. |
|
This PR is very old and needs changes to even address the issue in its current form (for instance, the same code should be replicated for BankerTypeOrigSend). I'm closing this and proposing to move discussion to #986. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering
pkg:Acallspkg:BBcan't send its own coins