Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: apply CLI flags to entire subtree #563

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

As pointed out in #555, the current command flag registration flow does not register flags with grandchild commands, and beyond.
This PR introduces a fix for allowing the most nested child commands to have flags of their entire ancestor tree.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

  • Manually verified that the issue has been resolved
  • Added unit tests that covered the issue functionality

Additional comments

Resolves #555

@zivkovicmilos zivkovicmilos requested a review from a team as a code owner March 6, 2023 12:13
@zivkovicmilos zivkovicmilos self-assigned this Mar 6, 2023
@faddat
Copy link
Contributor

faddat commented Mar 6, 2023

I really enjoyed the linting.

@moul moul merged commit f833e43 into gnolang:master Mar 6, 2023
@zivkovicmilos zivkovicmilos deleted the hotfix/upstream-config-parse branch March 6, 2023 13:35
harry-hov pushed a commit to harry-hov/gno that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

gnokey does not accept -pkgpath
3 participants