test(docker): address FIXMEs #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI output for the curious:
|
Sure that was my intention. Same for my other PRs. |
|
@tbruyelle can you rebase this PR with master? |
Also make query auth/account assertions more reliables.
tbruyelle
force-pushed
the
test/docker-maketx
branch
from
7ff1dd0
to
b442c65
Compare
Done! |
moul
approved these changes
Apr 3, 2023
grepsuzette
pushed a commit
to grepsuzette/gno
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is originated by #495, in order to add an integration test that broadcast TXs.
The following cases have been added to docker integration tests:
Note that to broadcast a tx I had to add the
test1account key in the running container, thanks to the seed.Also address others FIXMEs:
waitGnoland(): improve by looking at the logs instead of waiting 20scheckDocker(): implement by looking atdocker infooutputbuildDockerImage(): remove output check, assuming that ifdocker buildfails, the command will return an errorcleanupGnoland(): use onlydocker rm -fbecause it also kills the container if it's running.