Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add misc/genprotoc/Makefile #755

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

moul
Copy link
Member

@moul moul commented Apr 18, 2023

I forgot to add it during #585.


$ git clean -fxd
$ go mod tidy; echo $?
0

Addresses partially #749.

Fixes #749.

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Apr 18, 2023
@moul moul mentioned this pull request Apr 18, 2023
@moul moul marked this pull request as ready for review April 18, 2023 21:34
@moul moul requested a review from a team as a code owner April 18, 2023 21:34
moul added 4 commits April 18, 2023 23:45
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@tbruyelle
Copy link
Contributor

After I ran make -C misc/genproto, I have a small diff in tm2/pkg/amino/tests/pb/tests.pb.go and
tm2/pkg/amino/tests/proto3/proto/compat.pb.go, related to the protoc version.

 // Code generated by protoc-gen-go. DO NOT EDIT.
 // versions:
-// 	protoc-gen-go v1.30.0
+// 	protoc-gen-go v1.28.1-devel

Maybe that's something we can fix by using buf instead of protoc, since it's a go tool, we can probably add it to our misc/devdeps so we get a stable version for everyone.

But we can also probably do that later.

@moul
Copy link
Member Author

moul commented Apr 19, 2023

§I appreciate the suggestion and we may consider implementing it at a later time, maybe after the exploration of the JS client by @zivkovicmilos.

Since this package is solely for testing, the minor difference can be ignored if forgotten during rebasing. Implementing support for buf is not a priority, and its implementation with Amino could be challenging without limiting it to this specific file. It's noteworthy that genproto calls are currently rare

@moul moul merged commit 3d58898 into gnolang:master Apr 19, 2023
@moul moul deleted the dev/moul/genproto-makefile branch April 19, 2023 14:28
peter7891 pushed a commit that referenced this pull request May 9, 2023
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

go mod tidy fails
2 participants